Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow missing EQ or CB results #56

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Conversation

AlexAxthelm
Copy link
Contributor

@AlexAxthelm AlexAxthelm commented Jan 2, 2025

Currently, if either equity or bonds results are missing from the analysis (because the portfolio doesn't include those asset classes) then dashboarding process fails with an error:

cannot open compressed file '/home/workflow-pacta-webapp/create-dashboard183733793/analysis-output/Bonds_results_portfolio.rds', probable reason 'No such file or directory'

This PR allows the process to continue even if one of those files is missing.

Note: tests for EQ- and CB-only portfolios added in 3c443af

@AlexAxthelm AlexAxthelm changed the title Increment version number to 0.0.0.9010 Allow missing EQ or CB results Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Docker build status

commit_time git_sha image
2025-01-06T09:58:14Z 2d75e4b ghcr.io/rmi-pacta/workflow.pacta.dashboard:main

Copy link

github-actions bot commented Jan 2, 2025

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2025-01-06 10:07 UTC

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (df295d0) to head (2d75e4b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
R/prepare_pacta_dashboard_data.R 0.00% 20 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main     #56   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         25      25           
  Lines       1192    1208   +16     
=====================================
- Misses      1192    1208   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdhoffa
Copy link
Member

jdhoffa commented Jan 3, 2025

Likely closes #55

@AlexAxthelm AlexAxthelm linked an issue Jan 3, 2025 that may be closed by this pull request
@AlexAxthelm AlexAxthelm marked this pull request as ready for review January 3, 2025 11:44
@AlexAxthelm AlexAxthelm self-assigned this Jan 3, 2025
@jdhoffa jdhoffa merged commit 940f429 into main Jan 6, 2025
31 checks passed
@jdhoffa jdhoffa deleted the fix/55-allow-missing-eq-or-cb branch January 6, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle situations where bonds (or equity) data is missing
2 participants