Initially aggregate loans by appropriate groups. #270
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hasty in writing #263, in which I added an aggregation step to aggregate similar loans to different companies, if these loans mapped to the same ALD company. I used a
group_by_at(...)
, andsetdiff()
to aggregate by all but a few columns, which was lazy of me, and didn't think about the downstream issues of grouping by a set of columns that should in fact map to the same information.Here, I have made the aggregation step more specific, by grouping only by the relevant columns:
Relates to #262
Closes #265