Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lifecycle experimental badge #17

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Add lifecycle experimental badge #17

merged 3 commits into from
Jan 30, 2024

Conversation

jdhoffa
Copy link
Member

@jdhoffa jdhoffa commented Jan 29, 2024

experimental or maturing here?

I expect we still may want to totally revamp our pkgdown sites.

@jdhoffa jdhoffa requested a review from cjyetman January 29, 2024 09:57
@cjyetman
Copy link
Member

my not-so-important opinion here is that this repo is "mature" in that it does what it's supposed to do, we've been actively using it on public facing pages for many months, and there's no unsolved problems or bugs to fix (that I'm aware of). Sure, we may decide to change up the styling, but the basic functionality is pretty stable.

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 29, 2024

Hmm, so it seems that the stage maturing has been deprecated LOL

https://lifecycle.r-lib.org/articles/stages.html#maturing

tidyverse folks argued that there was no real/ actionable difference between maturing and experimental. Either something has a stable API or it doesn't...

I think this will warrant us to more precisely define what/ how we want to define our stages

@AlexAxthelm
Copy link
Contributor

+1 for mature.

Rationale: This repo doesn't have many PRs against it, and even if it did, none of them would be introducing what we would consider "breaking changes" for the rendered HTML.

@cjyetman
Copy link
Member

I'd say it's "stable" then since how it's used is unlikely to change, though it's content/styling might change

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 29, 2024

Sounds good :-)

@jdhoffa
Copy link
Member Author

jdhoffa commented Jan 29, 2024

Will change tomorrow when I'm back at the computer

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Alex Axthelm <[email protected]>
@jdhoffa jdhoffa requested a review from AlexAxthelm January 30, 2024 08:37
@jdhoffa jdhoffa merged commit 6c52426 into main Jan 30, 2024
1 check passed
@jdhoffa jdhoffa deleted the add-lifecycle-badge branch January 30, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants