Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link directly to pages and files on the PACTA website #390

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

cjyetman
Copy link
Member

No description provided.

@cjyetman cjyetman requested a review from jdhoffa January 28, 2025 18:19
@cjyetman cjyetman requested a review from jacobvjk as a code owner January 28, 2025 18:19
Copy link

github-actions bot commented Jan 28, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-03 09:35 UTC

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.97%. Comparing base (190409e) to head (76b59d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   79.97%   79.97%           
=======================================
  Files          29       29           
  Lines        3186     3186           
=======================================
  Hits         2548     2548           
  Misses        638      638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdhoffa
Copy link
Member

jdhoffa commented Jan 30, 2025

PR Preview Action v1.6.0
🚀 View preview at
https://RMI-PACTA.github.io/pacta.multi.loanbook/pr-preview/pr-390/

Built to branch gh-pages at 2025-01-28 18:39 UTC.

Preview will be ready when the GitHub Pages deployment is complete.

Strange, I'm getting a 404 not found for the deployed preview

Copy link
Member

@jdhoffa jdhoffa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, however as noted in the PR comment, I wasn't able to test this in the deployed preview.

@cjyetman
Copy link
Member Author

@cjyetman
Copy link
Member Author

probably should link directly to the training page from the running the analysis page too

@cjyetman
Copy link
Member Author

and metrics tab from the interpretation page

@cjyetman cjyetman requested a review from jdhoffa January 30, 2025 13:00
@cjyetman cjyetman merged commit 0d0774a into main Feb 3, 2025
12 checks passed
@cjyetman cjyetman deleted the link-directly-to-pages-and-files branch February 3, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants