-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft ggplot based sankey plot #367
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
- Coverage 80.05% 79.97% -0.09%
==========================================
Files 29 29
Lines 3269 3186 -83
==========================================
- Hits 2617 2548 -69
+ Misses 652 638 -14 ☔ View full report in Codecov by Sentry. |
@cjyetman @jdhoffa the PR is unfortunately rather large as it replaces long ish sankey functions. This is roughly what you should expect:
|
middle_node2 = "sector" | ||
ggplot2::ggsave( | ||
plot = p_sankey, | ||
filename = glue::glue("plot_{output_file_sankey_sector}.png"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where does output_file_sankey_sector
come from in this updated script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lines 159-163
alignment_metric < 0 ~ "Not aligned", | ||
TRUE ~ "Unknown" | ||
), | ||
middle_node = tools::toTitleCase(!!rlang::sym(middle_node)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure, but I would've guessed that using tools::toTitleCase()
would require adding tools
to the DESCRIPTION
file to avoid a R CMD check warning? (I know tools
is included in base R, but I thought R CMD check was picky enough about that 🤷🏻)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently not though, no notes in the CI checks
closes #364
ggalluvial
andggrepel
instead ofwebshot
andnetworkD3
example of new sankey plot: