fix tab bar position to the bottom of the header when scrolling #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker build status
|
|
This looks awesome! |
|
Though there is a rather odd bug with the
|
tbh would call this non-blocking, and extract that to a new issue (unless you immediately can think of a way to address it?) |
jdhoffa
previously approved these changes
Dec 11, 2024
🤣 so bizarre, I guess the subscript has a z-index somehow, looks like setting a z-index on the tab bar fixes this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on @jdhoffa's suggestion here #94 (comment), with additional CSS to complete the job