Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rect3D and Rect2D and change Color to RGBA #30

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Add Rect3D and Rect2D and change Color to RGBA #30

merged 6 commits into from
Oct 22, 2024

Conversation

NicEastvillage
Copy link
Contributor

No description provided.

@NicEastvillage
Copy link
Contributor Author

@VirxEC, do you know if I can give Color.a a default value of 255 without breaking anything?

@NicEastvillage NicEastvillage mentioned this pull request Oct 22, 2024
Merged
@VirxEC
Copy link
Contributor

VirxEC commented Oct 22, 2024

rlbot_flatbuffers_py will still have the default as 0, I would have to change things. But nothing will break, and I think that's a smart change.

@VirxEC
Copy link
Contributor

VirxEC commented Oct 22, 2024

However, changing the order of items in Color is a breaking change. Therefore this will result in RLBotServer v0.3

@NicEastvillage NicEastvillage merged commit 89c82c6 into main Oct 22, 2024
@NicEastvillage NicEastvillage deleted the rectangles branch October 22, 2024 19:56
@NicEastvillage
Copy link
Contributor Author

I'll let you handle the default value in rlbot_flatbuffers_py

@NicEastvillage
Copy link
Contributor Author

It broke core :(
https://github.com/RLBot/core/actions/runs/11467640018/job/31910984806?pr=55

@NicEastvillage
Copy link
Contributor Author

NicEastvillage commented Oct 22, 2024 •
edited
Loading

[Structs are] similar to a table, only now none of the fields are optional (so no defaults either), and fields may not be added or be deprecated
- https://flatbuffers.dev/flatbuffers_guide_writing_schema.html, emphasis mine

So I guess the interfaces has to implement such a default.

I am pushing a fix directly to main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicEastvillage @VirxEC