Adding Noob Black #332
Adding Noob Black #332
Conversation
| def next_bounce(pos, vel, height, g): | ||
| def solve_quadratic(a, b, c, ans, side): |
There was a problem hiding this comment.
You could gain many performance improvements by making these nested functions into methods or global functions. Currently, then are redefined every tick.
There was a problem hiding this comment.
Not only is your bot basically one file, it is also basically one function (with nested ones instead). Impressive.
Maybe your next endeavour should be learning how to structure your bot in multiple files and delete the stuff you don't use. You could also improve your code by getting rid of magic numbers.
I need you to fix your tags before I accept the PR.
RLBotPack/Noob_Black/src/bot.cfg
Outdated
| fun_fact = The bot has a Roblox background. | ||
|
|
||
| # Tags | ||
| tags = goalie, teamplay, rumble, hoops |
There was a problem hiding this comment.
The goalie tag is reserved for bots that ONLY play goalie. The rumble tag is for bots that use the rumble items.
|
The tags have been changed. |
This version of Noob Black is the same one that has been modified to fit v5, only that it works for v4.