Imagine U and I #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ActuallyTaylor <[email protected]>
…t into LCDDisplay.
…he enums so they make a bit more sense.
…lly functional and just requires some fine-tuning & for canopen to be re-integrated/fixed
aclowmclaughlin
changed the title
mjmagee991
requested changes
Feb 9, 2024
…e, and added a comment explaining the scoping for the switch statement in LCDView.display().
…ign' into feature/aclowmclaughlin/UI_Redesign # Conflicts: # src/charge_controller/dev/UIController.cpp
mjmagee991
approved these changes
Feb 10, 2024
Co-authored-by: Matthew Magee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a UI for the charge controller so that the battery charging voltage and current can be changed without having to manually change the code. A bunch was changed, but a basic summary is that now the LCDDisplay, ControllerModel, and ControllerUI class are in a MVC relationship (ControllerModel is the Model, LCDDisplay is the view, and ControllerUI is the Controller).