Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards: slstk3402a: add support #8802

Merged
merged 4 commits into from
Jun 4, 2018
Merged

boards: slstk3402a: add support #8802

merged 4 commits into from
Jun 4, 2018

Conversation

basilfx
Copy link
Member

@basilfx basilfx commented Mar 20, 2018

Contribution description

This PR add supports for the Silicon Labs SLSTK3402a. The files are similar to the SLTB001a and STK3600, STK3700 and SLSTK3401a already supported. The main difference with the STK3x00 is that is has a second series MCU and it has a memory LCD (supported by U8g2). This MCU also provides two crypto accelerators, and a hardware number generator.

I can provide remote access to the hardware, if needed.

Issues/PRs references

#8585
#8520
#8630

@basilfx basilfx added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: boards Area: Board ports labels Mar 20, 2018
@basilfx basilfx requested review from jia200x and kYc0o March 20, 2018 07:01
@basilfx basilfx added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 20, 2018
@basilfx basilfx changed the title Feature/efm32 slstk3402a boards: slstk3402a: add support Mar 20, 2018
@basilfx basilfx force-pushed the feature/efm32_slstk3402a branch from 4c9d367 to 60e7f3d Compare March 22, 2018 21:10
@basilfx basilfx mentioned this pull request Apr 3, 2018
Merged
@basilfx basilfx force-pushed the feature/efm32_slstk3402a branch from 60e7f3d to 9243402 Compare April 4, 2018 19:05
@basilfx
Copy link
Member Author

basilfx commented Apr 4, 2018

Updated vendor headers per #8873.

@basilfx basilfx added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Apr 4, 2018
@basilfx basilfx added this to the Release 2018.04 milestone Apr 11, 2018
@kaspar030 kaspar030 removed this from the Release 2018.04 milestone Apr 11, 2018
@basilfx basilfx force-pushed the feature/efm32_slstk3402a branch 2 times, most recently from 6bbe631 to 997ff28 Compare May 25, 2018 18:49
@basilfx basilfx removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 25, 2018
@basilfx
Copy link
Member Author

basilfx commented May 25, 2018 •
edited
Loading

Rebased. I squashed the fixup because the PR wasn't commented on (yet).

@basilfx basilfx added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 26, 2018
kYc0o
kYc0o reviewed May 28, 2018
View reviewed changes
boards/slstk3402a/include/board.h
* @{
*/
#define XTIMER_HZ (250000UL)
#define XTIMER_WIDTH (16)
Copy link
Contributor

@kYc0o kYc0o May 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if all boards are configured like this, but it looks a bit weird. Isn't possible to run the timer at 1MHz? 250KHz is a scaled frequency so you might run in the troubles as in #9049. Can you verify?

Copy link
Member Author

@basilfx basilfx May 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other boards are the same. I changed to 250kHz because I did not have enough 'accuracy' to play with. It uses two 16-bit timers in cascading mode, although this chip (generation) has support for a 32-bit timer that I will add support for.

@kYc0o
Copy link
Contributor

kYc0o commented May 30, 2018

Is this conflicting with the I2C rework? Because I'd like to merge it but obviously the I2C would be a blocker.

@aabadie
Copy link
Contributor

aabadie commented May 30, 2018

Is this conflicting with the I2C rework?

Yes, because there's a configuration for an I2C peripheral in the board periph_conf. And with the I2C rework, the board configuration needs to be updated (with an extra bus speed parameter).

@basilfx
Copy link
Member Author

basilfx commented May 30, 2018

There is already a PR to adapt the boards: #9208. Adding this one is not so hard. So when merged, I can adapt that one.

@basilfx
Copy link
Member Author

basilfx commented May 31, 2018

Alternatively, I could remove I2C support for the time being? What do you think, @aabadie/@kYc0o?

@kYc0o
Copy link
Contributor

kYc0o commented May 31, 2018

I'd say yes, I trust you won't forget 😉

@basilfx basilfx force-pushed the feature/efm32_slstk3402a branch from 997ff28 to 866f151 Compare May 31, 2018 12:34
@basilfx
Copy link
Member Author

basilfx commented May 31, 2018

Removed I2C definitions for now. See 866f151.

@kYc0o
Copy link
Contributor

kYc0o commented Jun 1, 2018

Did you remove the feature? I guess Murdock complains about it.

@basilfx basilfx force-pushed the feature/efm32_slstk3402a branch 2 times, most recently from 71f899c to 52563a8 Compare June 2, 2018 15:32
@basilfx
Copy link
Member Author

basilfx commented Jun 2, 2018

@kYc0o I forgot to remove that features, yes. Now the build is OK. Can I squash?

@kYc0o
Copy link
Contributor

kYc0o commented Jun 3, 2018

Yes please squash.

@basilfx basilfx force-pushed the feature/efm32_slstk3402a branch from 52563a8 to bfb820b Compare June 3, 2018 14:48
@basilfx
Copy link
Member Author

basilfx commented Jun 3, 2018

Squashed and rebased.

kYc0o
kYc0o approved these changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@kYc0o kYc0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@kYc0o kYc0o merged commit 42d5837 into RIOT-OS:master Jun 4, 2018
@cladmi cladmi added this to the Release 2018.07 milestone Jul 10, 2018
@basilfx basilfx mentioned this pull request Aug 5, 2018
Merged
@basilfx basilfx deleted the feature/efm32_slstk3402a branch January 14, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kYc0o kYc0o kYc0o approved these changes

@jia200x jia200x Awaiting requested review from jia200x

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms
Projects
None yet
Milestone
Release 2018.07
Development

Successfully merging this pull request may close these issues.
5 participants
@basilfx @kYc0o @aabadie @cladmi @kaspar030