Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nrfmin: port for gnrc_netif2 #7417

Merged
merged 1 commit into from
Oct 10, 2017
Merged

nrfmin: port for gnrc_netif2 #7417

merged 1 commit into from
Oct 10, 2017

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Jul 26, 2017 •
edited
Loading

Ports nrfmin for gnrc_netif2.

Depends on #7370.

This PR is part of the network layer remodelling effort:
PR dependencies

@miri64 miri64 added GNRC Area: network Area: Networking State: waiting for other PR State: The PR requires another PR to be merged first labels Jul 26, 2017
@miri64 miri64 requested a review from haukepetersen July 26, 2017 15:52
@miri64 miri64 force-pushed the gnrc_netif2/feat/nrfmin branch from 94a2d1d to efd8843 Compare July 30, 2017 18:43
@miri64 miri64 force-pushed the gnrc_netif2/feat/nrfmin branch from efd8843 to 5f987a3 Compare August 21, 2017 10:55
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 21, 2017
@miri64
Merge branch 'gnrc_netif2/feat/new-netif-api-for-gnrc' (RIOT-OS#7370)…
49d7983 
… into RIOT-OS#7417
@miri64
Copy link
Member Author

miri64 commented Aug 21, 2017

Rebased to current master and current dependencies

@miri64 miri64 force-pushed the gnrc_netif2/feat/nrfmin branch from 5f987a3 to 4597193 Compare October 10, 2017 09:49
@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed State: waiting for other PR State: The PR requires another PR to be merged first labels Oct 10, 2017
@miri64
Copy link
Member Author

miri64 commented Oct 10, 2017

Rebased to current master, no longer waiting for other PR

haukepetersen
haukepetersen approved these changes Oct 10, 2017
View reviewed changes
Copy link
Contributor

@haukepetersen haukepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look valid (though I must say I am looking forward to switching over solely to netif2 to get rid of all those ifdefs). Tested with gnrc_networking between nrf52dk and nrf52840dk, works as expected.

ACK

@miri64
Copy link
Member Author

miri64 commented Oct 10, 2017

(though I must say I am looking forward to switching over solely to netif2 to get rid of all those ifdefs)

Me as well.

@miri64 miri64 merged commit a295b0e into RIOT-OS:master Oct 10, 2017
@miri64 miri64 deleted the gnrc_netif2/feat/nrfmin branch October 10, 2017 10:09
@miri64 miri64 mentioned this pull request Nov 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haukepetersen haukepetersen haukepetersen approved these changes

Assignees

@haukepetersen haukepetersen

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @haukepetersen