Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ng_sixlowpan: Initial import of IP header compression #2806

Merged
merged 1 commit into from
May 27, 2015
Merged

ng_sixlowpan: Initial import of IP header compression #2806

merged 1 commit into from
May 27, 2015

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Apr 14, 2015

Depends on #2614. (merged)

@miri64 miri64 added Area: network Area: Networking State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first NSTF labels Apr 14, 2015
@miri64 miri64 added this to the Network Stack Task Force milestone Apr 14, 2015
This was referenced Apr 14, 2015
Closed
Merged
@miri64 miri64 force-pushed the ng_sixlowpan_iphc/feat/initial branch from 91cc2f7 to da21f08 Compare April 16, 2015 16:42
@miri64
Copy link
Member Author

miri64 commented Apr 16, 2015

Rebased to current dependencies

@miri64 miri64 force-pushed the ng_sixlowpan_iphc/feat/initial branch from da21f08 to dd3e461 Compare April 21, 2015 16:11
@miri64
Copy link
Member Author

miri64 commented Apr 21, 2015

Rebased to current #2614.

@miri64 miri64 force-pushed the ng_sixlowpan_iphc/feat/initial branch from dd3e461 to a1a9779 Compare April 22, 2015 23:18
@miri64
Copy link
Member Author

miri64 commented Apr 22, 2015

Rebased to current #2614.

@miri64 miri64 force-pushed the ng_sixlowpan_iphc/feat/initial branch from a1a9779 to 56204e3 Compare April 23, 2015 14:41
@miri64 miri64 removed State: waiting for other PR State: The PR requires another PR to be merged first State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet labels Apr 23, 2015
@miri64
Copy link
Member Author

miri64 commented Apr 23, 2015

Rebased to current master (and removed long out-dated WIP label)

@OlegHahm
Copy link
Member

Nice. Will review ASAP.

@miri64
Copy link
Member Author

miri64 commented Apr 23, 2015

(please review fragmentation first; I think this is more important right now)

@OlegHahm
Copy link
Member

Ok

@miri64 miri64 force-pushed the ng_sixlowpan_iphc/feat/initial branch 2 times, most recently from cbe231a to 8584bdf Compare April 27, 2015 08:07
@miri64
Copy link
Member Author

miri64 commented Apr 27, 2015

Rebased to current master

@miri64 miri64 force-pushed the ng_sixlowpan_iphc/feat/initial branch from c35d983 to dcb24f9 Compare April 29, 2015 08:11
@OlegHahm
Copy link
Member

Is this ready for review now?

@miri64
Copy link
Member Author

miri64 commented May 25, 2015

Yes

@miri64
Copy link
Member Author

miri64 commented May 25, 2015

Ever since I opened it ;-)

@miri64 miri64 force-pushed the ng_sixlowpan_iphc/feat/initial branch from d979b42 to e8ac480 Compare May 25, 2015 14:05
@miri64
Copy link
Member Author

miri64 commented May 25, 2015

Rebased and squashed, since obviously no review took place until now ;-)

@OlegHahm
Copy link
Member

Ever since I opened it ;-)

Why was it marked as "WIP" in the beginning then?

@miri64
Copy link
Member Author

miri64 commented May 25, 2015

Errrr… I meant when I removed that label ;-)

OlegHahm
OlegHahm reviewed May 26, 2015
View reviewed changes
sys/net/network_layer/ng_sixlowpan/iphc/ng_sixlowpan_iphc.c
&(iid->u8[(ctx->prefix_len / 8) - 7]),
sizeof(network_uint64_t) - ((ctx->prefix_len / 8) - 7)) == 0) &&
(addr->u8[(ctx->prefix_len / 8)] & byte_mask[ctx->prefix_len % 8]) ==
(iid->u8[(ctx->prefix_len / 8) - 8] & byte_mask[ctx->prefix_len % 8])));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments would be useful here

@miri64
Copy link
Member Author

miri64 commented May 26, 2015

Addressed comments

@miri64 miri64 force-pushed the ng_sixlowpan_iphc/feat/initial branch from c9ac6ea to 1cbb02b Compare May 26, 2015 19:17
@miri64
Copy link
Member Author

miri64 commented May 26, 2015

Squashed

@OlegHahm
Copy link
Member

untested ACK

@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 26, 2015
@miri64
Copy link
Member Author

miri64 commented May 27, 2015

Fixed doc error pointed out by Travis.

@jnohlgard jnohlgard mentioned this pull request May 27, 2015
Closed
@miri64 miri64 mentioned this pull request May 27, 2015
Closed
@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 27, 2015
@OlegHahm
Copy link
Member

re-ACK

@miri64 miri64 force-pushed the ng_sixlowpan_iphc/feat/initial branch from 58b23ef to 9a98926 Compare May 27, 2015 09:54
@miri64
Copy link
Member Author

miri64 commented May 27, 2015

Re-Squashed

miri64 added a commit that referenced this pull request May 27, 2015
@miri64
Merge pull request #2806 from authmillenon/ng_sixlowpan_iphc/feat/ini…
ae3d88f 
…tial

ng_sixlowpan: Initial import of IP header compression
@miri64 miri64 merged commit ae3d88f into RIOT-OS:master May 27, 2015
@miri64 miri64 deleted the ng_sixlowpan_iphc/feat/initial branch May 27, 2015 16:07
@OlegHahm OlegHahm removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@OlegHahm OlegHahm

Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Network Stack Task Force
Development

Successfully merging this pull request may close these issues.
2 participants
@miri64 @OlegHahm