Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended radio api and AT86RF231 implementation #2562

Closed
wants to merge 11 commits into from

Conversation

rousselk
Copy link
Contributor

@rousselk rousselk commented Mar 9, 2015

This PR completes the implementation of the AT86RF231 radio driver; the latter now implements all of the netdev_802154_driver_t features (that were until now only implemented as stubs), and adds some new options to this interface:

  • NETDEV_OPT_CAN_MONITOR indicates whether the transceiver can go into "monitor" (a.k.a.: "promiscuous") mode;
  • NETDEV_OPT_CCA_THRESHOLD for getting or setting the threshold value that is used by a transceiver to determine if radio channel is busy (CCA);
  • NETDEV_OPT_SFD_COUNT for getting and resetting the number of SFDs (start of frame delimiters) detected by the transceiver: I think it is a good indicator to help estimate the traffic on the radio medium;
    The two last options are planned to be used in future MAC protocol implementations.

@rousselk rousselk added Area: network Area: Networking Area: drivers Area: Device drivers labels Mar 9, 2015
@rousselk
Copy link
Contributor Author

rousselk commented Mar 9, 2015

Note that this enhanced driver has been tested with success on FIT IoT-LAB's M3 nodes.

@jnohlgard
Copy link
Member

How do I test this? Can I use the rpl_udp example? Do I need any particular commands in the rpl shell?

@rousselk
Copy link
Contributor Author

rousselk commented Mar 9, 2015

A new 'sfdcnt' shell command has been added in the shell (sys/shell/commands/sc_transceiver.c, see last commit).

@LudwigKnuepfer LudwigKnuepfer added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Mar 12, 2015
#include "transceiver.h"
#include "hwtimer.h"
#include "config.h"

#define ENABLE_DEBUG (0)
#define ENABLE_DEBUG (1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should stay disabled by default

@OlegHahm
Copy link
Member

Since @thomaseichinger is woring on the driver, too, I guess it makes sense if he reviews.

@rousselk rousselk force-pushed the extended-radio-api branch 2 times, most recently from 9900152 to a4df911 Compare March 27, 2015 12:19
@OlegHahm OlegHahm force-pushed the master branch 3 times, most recently from 9f184dd to 45554bf Compare March 31, 2015 13:01
@rousselk rousselk force-pushed the extended-radio-api branch 2 times, most recently from 34c4fd0 to 7544635 Compare April 3, 2015 13:35
@rousselk rousselk force-pushed the extended-radio-api branch from 7544635 to 5d927ad Compare April 13, 2015 11:56
@rousselk rousselk force-pushed the extended-radio-api branch from 5d927ad to a3d8147 Compare April 17, 2015 12:28
@PeterKietzmann
Copy link
Member

@rousselk @haukepetersen @bapclenet does it make sense to keep this PR open?

@PeterKietzmann
Copy link
Member

(just because of #2825)

@haukepetersen
Copy link
Contributor

For some reason I was un-aware of this PR. As far as I see it, it contains some functionality that is not included in the remodeled ng_at.. driver. So I say lets keep this open and try to merge the functionality to the new driver.

@OlegHahm OlegHahm assigned OlegHahm and unassigned thomaseichinger May 21, 2015
@OlegHahm OlegHahm assigned biboc and unassigned OlegHahm Jun 3, 2015
@biboc
Copy link
Member

biboc commented Jun 4, 2015

@rousselk, do you think you will have time to adapt your changes to the new at86rf2xx driver? Or should someone else do it.

@rousselk rousselk force-pushed the extended-radio-api branch 5 times, most recently from 5432031 to 65c548f Compare June 22, 2015 14:53
@rousselk rousselk force-pushed the extended-radio-api branch from 65c548f to 38d3771 Compare July 6, 2015 11:50
@rousselk rousselk force-pushed the extended-radio-api branch from 38d3771 to 826d292 Compare July 21, 2015 11:01
@OlegHahm
Copy link
Member

OlegHahm commented Aug 8, 2015

@bapclenet, @daniel-k, @thomaseichinger, any volunteers to port these changes to the new driver?

@daniel-k
Copy link
Member

daniel-k commented Aug 8, 2015

I'm too busy right now. Maybe sometime later if these features proof useful to me, but I need to get other things done at the moment, sorry.

@biboc
Copy link
Member

biboc commented Aug 19, 2015

The same as daniel-k, I'm too busy at the moment, I hope I will be able to work on RIOT soon.

@rousselk
Copy link
Contributor Author

I have just upgraded to current RIOT codebase (from 2014.12 release !).
This branch is now just irrelevant. I'm closing it, and will create a new branch/PR when ready.

@rousselk rousselk closed this Aug 31, 2015
@rousselk rousselk deleted the extended-radio-api branch August 31, 2015 08:38
@biboc
Copy link
Member

biboc commented Aug 31, 2015

Great! Thank you @rousselk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: drivers Area: Device drivers Area: network Area: Networking CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants