msp430: add assert header #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Type: enhancement
This was referenced Feb 11, 2015
Merged
| /** | ||
| * @see http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/assert.h.html | ||
| * | ||
| * @todo implement behaviour for NDEBUG defined. |
There was a problem hiding this comment.
Reading the docs, you already implemented behaviour for NDEBUG defined?
|
Addressed comments |
|
ACK when squashed. |
| /** | ||
| * @see http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/assert.h.html | ||
| * | ||
| * @todo implement behaviour for NDEBUG not defined. |
There was a problem hiding this comment.
Why not implement the rest right now?
There was a problem hiding this comment.
Because I was not sure if abort() is implemented on msp430
miri64
force-pushed
the
msp430/api/add-assert
branch
from
3bb8ab1
to
722a9e7
Compare
|
Added implementation. Decided to use |
| * @def assert | ||
| * @see http://pubs.opengroup.org/onlinepubs/9699919799/functions/assert.html | ||
| * | ||
| * @todo implement behaviour for NDEBUG not defined. |
|
Addressed comments |
|
ACK when squashed. |
miri64
force-pushed
the
msp430/api/add-assert
branch
from
d0ed730
to
f00e532
Compare
|
Squashed. Waiting for travis |
miri64
force-pushed
the
msp430/api/add-assert
branch
from
f00e532
to
9077299
Compare
|
Addressed @LudwigOrtmann's post-ACK comment. Can we merge it now… |
|
ACK ACK |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
assert()macro is needed forutlist(which is used in #2285 and #2404). Therefore we need an implementation ofassert().