Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/stm32f0: removed leftovers from slave mode #1713

Merged
merged 1 commit into from
Oct 2, 2014
Merged

cpu/stm32f0: removed leftovers from slave mode #1713

merged 1 commit into from
Oct 2, 2014

Conversation

haukepetersen
Copy link
Contributor

No description provided.

@haukepetersen haukepetersen added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Sep 25, 2014
@haukepetersen haukepetersen added this to the Release NEXT MAJOR milestone Sep 25, 2014
@Kijewski
Copy link
Contributor

These warning were not introduced by this PR, but please have a look nevertheless:

$ ./dist/tools/cppcheck/check.sh master --error-exitcode=0
cpu/stm32f0/periph/spi.c:37: style (unassignedVariable): Variable 'af' is not assigned a value.
cpu/stm32f0/periph/spi.c:69: error (nullPointer): Possible null pointer dereference: port
cpu/stm32f0/periph/spi.c:70: error (nullPointer): Possible null pointer dereference: port
cpu/stm32f0/periph/spi.c:72: error (nullPointer): Possible null pointer dereference: port
cpu/stm32f0/periph/spi.c:73: error (nullPointer): Possible null pointer dereference: port
cpu/stm32f0/periph/spi.c:77: error (nullPointer): Possible null pointer dereference: spi
cpu/stm32f0/periph/spi.c:78: error (nullPointer): Possible null pointer dereference: spi
cpu/stm32f0/periph/spi.c:79: error (nullPointer): Possible null pointer dereference: spi
cpu/stm32f0/periph/spi.c:84: error (nullPointer): Possible null pointer dereference: spi
cpu/stm32f0/periph/spi.c:87: error (nullPointer): Possible null pointer dereference: spi
cpu/stm32f0/periph/spi.c:90: error (nullPointer): Possible null pointer dereference: spi
cpu/stm32f0/periph/spi.c:93: error (nullPointer): Possible null pointer dereference: spi
cpu/stm32f0/periph/spi.c:96: error (nullPointer): Possible null pointer dereference: spi
cpu/stm32f0/periph/spi.c:73: error (uninitvar): Uninitialized variable: af

@haukepetersen
Copy link
Contributor Author

willl do

@haukepetersen
Copy link
Contributor Author

addressed the warnings thrown by cppcheck, the fist one (unassignedVariable) variable seems to a false positive though - initialized the var anyway...

@haukepetersen haukepetersen added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 26, 2014
@LudwigKnuepfer
Copy link
Member

/slap Travis

@thomaseichinger
Copy link
Member

squash and go for it!

@haukepetersen
Copy link
Contributor Author

squashed and go.

haukepetersen added a commit that referenced this pull request Oct 2, 2014
@haukepetersen
Merge pull request #1713 from haukepetersen/fix_stm32f0_spi
49364da 
cpu/stm32f0: removed leftovers from slave mode
@haukepetersen haukepetersen merged commit 49364da into RIOT-OS:master Oct 2, 2014
@haukepetersen haukepetersen deleted the fix_stm32f0_spi branch October 2, 2014 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@PeterKietzmann PeterKietzmann

Labels
CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2014.12
Development

Successfully merging this pull request may close these issues.
5 participants
@haukepetersen @Kijewski @LudwigKnuepfer @thomaseichinger @PeterKietzmann