Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Test suite should pass #22

Closed
RIAEvangelist opened this issue Jun 22, 2015 · 4 comments
Closed

Address Test suite should pass #22

RIAEvangelist opened this issue Jun 22, 2015 · 4 comments
Assignees

Comments

@RIAEvangelist
Copy link
Owner

Address

1) should create Address object from JSON
✓ should create Address object from string
✓ should return full address to pass to findNearbyStores
2) should return zip code to pass to findNearbyStores
3) should return city, state, zip to pass to findNearbyStores
✓ should create Address object from array
@RIAEvangelist RIAEvangelist self-assigned this Jun 22, 2015
@madelinecameron
Copy link
Collaborator

What's the errors? Mine is passing those just fine.

@madelinecameron
Copy link
Collaborator

It looks like you might have an older version of teh code because I know the failing test #2 and #3 are ones that were failing until I made a change recently. I believe all of my changes have been pushed into PizzaPI (both the branch and my own repository, although I am using only the branch now)

RIAEvangelist added a commit that referenced this issue Jun 22, 2015
@RIAEvangelist
Copy link
Owner Author

FYI, you know if you work in this repo, you can do a git fetch upstream to update your repo, right?

@RIAEvangelist
Copy link
Owner Author

Lets review the Address Class from commit 6f4b8f3

I think it is a very transparent method, and keeps scoping very clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants