This repository has been archived by the owner on Dec 14, 2024. It is now read-only.
Nip in the Bud Updates & VHS Effect for Retro TV! #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstrlJelly
suggested changes
Jul 4, 2024
| @@ -89,20 +109,34 @@ public class NipInTheBud : Minigame | |||
| { | |||
| public static NipInTheBud instance; | |||
There was a problem hiding this comment.
it'd be nice if we could set a standard of never using static instances when unneeded, just use eventCaller.gameManager.TryGetMinigame() in the events list or gameManager.TryGetMinigame() in the minigame script
| @@ -116,42 +150,60 @@ public override void OnBeatPulse(double beat) | |||
| { | |||
| if (BeatIsInBopRegion(beat)) | |||
There was a problem hiding this comment.
bop regions are less flexible and less optimized (though it doesn't matter too much) than just making a list of beataction actions and making a new beataction with that
| if (allEventsBeforeBeat.Count > 0) | ||
| { | ||
| allEventsBeforeBeat.Sort((x, y) => x.beat.CompareTo(y.beat)); //just in case | ||
| var lastEvent = allEventsBeforeBeat[^1]; |
There was a problem hiding this comment.
instead of FindAll, use FindLast. it spends less time finding objects and doesn't create a new list. the sorting is also redundant, as whenever events can be used, they're sorted. if they aren't, we have an even bigger issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some features to Nip in the Bud:
Added more options to the Retro TV filter, bumping it up from F tier to a solid E-!