Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always check pid before clearing workspace #1321

Merged
merged 3 commits into from
Mar 5, 2023
Merged

Always check pid before clearing workspace #1321

merged 3 commits into from
Mar 5, 2023

Conversation

ElianHugh
Copy link
Collaborator

Ensure that we aren't clearing the workspace too eagerly.

  • Only clean the workspace if the current pid === stored pid

What problem did you solve?

If you attach two terminals, closing the first one will cause vscode-R to detach the second one

ElianHugh added 2 commits March 5, 2023 22:30
@ElianHugh
Check pid before clear
4aaa514 
Ensure that we aren't clearing the workspace too eagerly.
@ElianHugh
Update rTerminal.ts
b18d97d
renkun-ken
renkun-ken reviewed Mar 5, 2023
View reviewed changes
R/session/vsc.R Outdated Show resolved Hide resolved
@renkun-ken renkun-ken merged commit bb929c4 into REditorSupport:master Mar 5, 2023
@renkun-ken renkun-ken mentioned this pull request Jul 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renkun-ken renkun-ken renkun-ken left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElianHugh @renkun-ken