-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added expression tool to ease parameter sweeps of recetox-aplcms on Galaxy #624
base: master
Are you sure you want to change the base?
Conversation
maybe @mvdbeek has an opinion on this as well? I didn't figure how to read the passed csv file in the ECMA script but I tried to include some validation logic on the file contents. |
that's the point of it, you can't do I/O while executing ecmascript making this a safe choice for evaluating expressions. |
Thanks, ok that makes sense. So do you think that the tool is fine like this? Probably the number of characters can be significantly reduced but apart from that? @bgruening has some concerns about this |
Honestly this is brilliant and what I hope will happen more in the future. What are the concerns ? |
When I say more I hope we can just let people write these expressions directly without having to write a separate standalone tool. The UI will be tricky to get right, but if you only do the one exact thing you need to do I think this reduces workflow and tool complexity a lot. |
My concern was that it is too specific to the aplcms use-case. I would write this tool more generally and get it upstream or in IUC. I will look at it more tomorrow. |
This PR adds an expression tool to the recetox_aplcms suite that parses the parameters sweeped during peak detection.
This tool can be extended to contain more parameters in the future.