Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update matchms to 0.22.0" #399

Closed
wants to merge 1 commit into from
Closed

Conversation

hechth
Copy link
Member

@hechth hechth commented Sep 13, 2023

Reverts #395

@bernt-matthias
Copy link
Contributor

Just noticed that the TS seems to contain only version 0.17.

Is the deploy failure notification running on this repo: https://github.com/bernt-matthias/recetox-galaxytools/blob/7bc1710e91d5b1f07326c4eb3b96d4162be4e87d/.github/workflows/pr.yaml#L419?

@hechth
Copy link
Member Author

hechth commented Sep 19, 2023

@bernt-matthias yeah we seem to have some issues on the CI in general with deploying the tools to the toolshed and collecting the test results - I'm a bit puzzled at the moment.

@bgruening
Copy link
Collaborator

Is it in sync with the IUC GitHub actions?

@bernt-matthias
Copy link
Contributor

Seems so. If Pat is defined the bot should respond if deployment failed

token: ${{ secrets.PAT }}

@hechth
Copy link
Member Author

hechth commented Sep 20, 2023

The slash CI action actually complains that PAT is invalid - also, I think this secret was generated by @martenson back then - maybe it somehow got outdated?

AFAIK this is a GitHub personal access token? Or what kind of token is this?

@martenson
Copy link
Member

The deploy step seems skipped due to failing tests or am I seeing it incorrectly?

@hechth
Copy link
Member Author

hechth commented Sep 21, 2023

The deploy step seems skipped due to failing tests or am I seeing it incorrectly?

@martenson All tests are passing locally. Also the slash command dispatch stopped working saying bad credentials.

@bernt-matthias
Copy link
Contributor

Then a new PAT is needed.

@hechth hechth closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants