-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring data reading and writing #116
Conversation
Co-authored-by: Wudmir Y. Rojas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps rename file to match function name, for consistency: test_data_extract_ri.py --> test_data_init_ri_from_comment.py ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic behind the changes looks good to me.
Closes #59
Please re-create the environment for testing and reviewing these changes based on the poetry.yaml file.
float
- they are now no longer allowed to beNone