Command reordering not saving #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorder now fails because a POST request is being sent to /commands/reorder and the application only accepts /projects/{project}/commands/reorder due to the prefix in routes/api.php .
|
D'oh! thanks I'll get this merged in later today |
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
============================================
- Coverage 86.07% 85.86% -0.21%
Complexity 1054 1054
============================================
Files 174 174
Lines 3403 3403
============================================
- Hits 2929 2922 -7
- Misses 474 481 +7Continue to review full report at Codecov.
|
|
Sorry, got distracted last night with Laravel 5.4.14 breaking loads of the tests. I shall merge this tonight before I do anything else |
|
Sure, no problem! Thanks. |
REBELinBLUE
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorder now fails because a POST request is being sent to /commands/reorder and the application only accepts /projects/{project}/commands/reorder due to the prefix in routes/api.php .
Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].
In raising this pull request, I confirm the following (please check boxes):
NOTE: The last 2 are not required to open a PR and can be done afterwards /
while the PR is open.
Description of change
Reorder now fails because a POST request is being sent to /commands/reorder and the application only accepts /projects/{project}/commands/reorder due to the prefix in routes/api.php .