-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Socket should also connect to redis specified in .env #213
Conversation
Im actually using the redis in docker means another machine it has its own ip address, all are working fine but notifications when deploying are not working, when i debugged in the `socket.js` it is connecting to local redis instance rather than redis that is specified in the .env file. I think it is better to connect to redis which is specified in .env. Generally when using the remote redis it is preferrable to have a password so i have given the option to specify the `redis_password`
Thanks, I'll merge it this evening |
Could you add the default values to Thanks |
db: process.env.REDIS_DATBASE || 0 | ||
port: process.env.REDIS_PORT || 6379, | ||
host: process.env.REDIS_HOST || '127.0.0.1', | ||
db: process.env.REDIS_DATBASE || 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed, this should be REDIS_DATABASE
(I know, it was wrong before also). Would you mind changing it?
Thanks
Default values is nothing for password and database, so im leaving it empty. |
Thanks |
Turns out that doesn't work, leaving them empty results in them becoming empty values in the config, not the defaults so I have set the defaults in |
In raising this pull request, I confirm the following (please check boxes):
NOTE: The last 2 are not required to open a PR and can be done afterwards /
while the PR is open.
Description of change
Please provide a description of the change here.
Im actually using the redis in docker means another machine it has its own ip address, all are working fine but notifications when deploying are not working, when i debugged in the
socket.js
it is connecting to local redis instance rather than redis that is specified in the .env file. I think it is better to connect to redis which is specified in .env. Generally when using the remote redis it is preferrable to have a password so i have given the option to specify theredis_password