Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include the project name in the comment for the SSH key #324

Closed
bbashy opened this issue Feb 27, 2017 · 7 comments
Closed

Include the project name in the comment for the SSH key #324

bbashy opened this issue Feb 27, 2017 · 7 comments
Labels
Context: Console/Jobs Context: DB Context: Frontend/UI Enhancement Priority: Medium

Comments

@bbashy
Copy link
Contributor

bbashy commented Feb 27, 2017 •
edited
Loading

Hi,

Just wondering if we can get the project name within the comment of the ssh-rsa key that's generated here for the servers: https://github.com/REBELinBLUE/deployer/blob/master/resources/scripts/tools/GenerateSSHKey.sh

I have multiple deployments within one user so I have a few in the authorized_keys file and I don't know which are which since it just has deploy@deployer.

Should of added comments as I added them but would be nice to have it there?

Thanks.
@REBELinBLUE
Copy link
Owner

ooh, good idea!

@REBELinBLUE
Copy link
Owner

I've rewritten the key generation to make it more testable so I can't do this quite yet as I'll just need to redo it, but I should have the refactoring merged in by the weekend then I will do this

@bbashy
Copy link
Contributor Author

bbashy commented Feb 27, 2017

Totally fine! Thanks.

REBELinBLUE added a commit that referenced this issue Mar 3, 2017
@REBELinBLUE
#324 - Use the project name as the comment field for the SSH key
4d1aa50
REBELinBLUE added a commit that referenced this issue Mar 3, 2017
@REBELinBLUE
Merge branch 'feature/324_key_name'
c9949a1 
* feature/324_key_name:
  #324 - Use the project name as the comment field for the SSH key
@REBELinBLUE
Copy link
Owner

This is now in master, would you mind checking it out? Working OK for me

@REBELinBLUE REBELinBLUE changed the title [REQ] ssh-rsa comment to include project name Include the project name in the comment for the SSH key Mar 3, 2017
@bbashy
Copy link
Contributor Author

bbashy commented Mar 3, 2017 •
edited
Loading

Works! Wouldn't mind keeping deployer in there would you?

Or something along the lines of

ssh-rsa AAAAB3NzaC1yc2EAblahblahblahI4r/CuIQA1OsCzAQ== worker@deployer - ProjectName

@REBELinBLUE
Copy link
Owner

Makes sense, I will do that

@REBELinBLUE
Copy link
Owner

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Context: Console/Jobs Context: DB Context: Frontend/UI Enhancement Priority: Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bbashy @REBELinBLUE