Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects using git submodules are not supported #264

Closed
6 tasks done
alex-osborn opened this issue Sep 5, 2016 · 2 comments
Closed
6 tasks done

Projects using git submodules are not supported #264

alex-osborn opened this issue Sep 5, 2016 · 2 comments

Comments

@alex-osborn
Copy link

Before submitting your issue, please make sure that you've checked all of the checkboxes below.

  • You're running the latest release version of Deployer.
  • Ensure that you're running at least PHP 5.5.9, you can check this by running php -v
  • You've ran composer install --no-dev from the root of your installation.
  • You've ran npm install --production from the root of your installation.
  • You've ran rm -rf bootstrap/cache/* from the root of your installation.
  • You have restarted the queue listener and node socket server.

To help us better understand your issue, please answer the following.

Expected behaviour

Git submodules are included in the project archive created during deployment the local mirror.

Actual behaviour

Git submodules are not included via git archive.

Steps to reproduce

Run a deployment.

Ran into an issue I wasn't expecting when deploying a project - the git archive command does not support submodules.

From a little research, the accepted method to attack this is to is a wrapper. One example:
https://github.com/meitar/git-archive-all.sh/wiki

What do you think about this? If you're happy this would be in scope for deployer, I can work on a pull request?

CreateReleaseArchive.sh could just be updated directly, or another approach would be to create a separate script, and hide this behind a UI toggle when setting up the project, i.e. "Include GIT submodules?".

@REBELinBLUE
Copy link
Owner

Ah, bugger, I forgot to check that when switching to using git-archive! I will take a look

@REBELinBLUE REBELinBLUE modified the milestones: 0.0.39, 0.0.40 Oct 21, 2016
@REBELinBLUE
Copy link
Owner

REBELinBLUE commented Oct 23, 2016

OK been looking into this, turns out it'll take a bit of work as the archive uses a mirror of the repo (a bare repository) so can't init the submodules when creating the archive. I will have to look into rewriting how the archive is created

REBELinBLUE added a commit that referenced this issue Oct 31, 2016
* bug/264:
  Fixes #264 - Adds the git-archive-all.sh script to allow submodules to work
REBELinBLUE added a commit that referenced this issue Nov 13, 2016
* master:
  Updated CHANGELOG
  Remove lang task
  Removed nodemon
  Added a start command for npm
  Added nodemon
  Update README.md
  Fixes #264 - Adds the git-archive-all.sh script to allow submodules to work
  Clean up
  Fixing travis, finally
  Don't run optimize on travis
  Still debugging travis issue
  Still debugging travis issue
  Testing travis
  Updated dependencies
  Allow the beanstalkd port to be supplied (#281)
  Return non-zero status code on failure
@REBELinBLUE REBELinBLUE removed this from the 0.0.40 milestone Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants