Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI issues in modals, deploy button #161

Closed
alsotop opened this issue Jan 29, 2016 · 2 comments
Closed

Minor UI issues in modals, deploy button #161

alsotop opened this issue Jan 29, 2016 · 2 comments

Comments

@alsotop
Copy link

alsotop commented Jan 29, 2016

Modals slightly disappear behind the header because their z-index is less than it:
http://i.imgur.com/9Ve5Rlb.png
.main-header has a z-index: 21 and .modal has a z-index: 10

Deploy button incorrectly styled because the Deploy text is within the span for fontawesome icon instead of outside the span:
http://i.imgur.com/I6GMbPm.png
This could be changed to:
<button id="deploy_project" data-toggle="modal" data-backdrop="static" data-target="#reason" type="button" class="btn btn-danger" title="Deploy the project"><span class="fa fa-cloud-upload"></span> Deploy</button>

@REBELinBLUE
Copy link
Owner

Yeah we noticed this at work today,it only seems to happen in production mode with minified CSS & HTML. Will try and get it fixed this evening

REBELinBLUE added a commit that referenced this issue Jan 30, 2016
* master:
  Fixes #161
  Fixes issue with the dialog appear behind the toolbar when using minified CSS by switching the to version of bootstrap included with AdminLTE
  Comment
  Updated build script
  Insert newly created groups straight into the sidebar
  Changed ID which is used
  Fixes #74 by appending the new project to it's group in the menu
  Updated changelog
  Updated changelog
  Incremented version
@REBELinBLUE
Copy link
Owner

Fixed the problem, I've merged it into the release branch so you can switch to it without having to install the dev dependencies you'd need to run from master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants