Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tokens for deployer and committer users #123

Closed
alsotop opened this issue Nov 3, 2015 · 4 comments
Closed

Add tokens for deployer and committer users #123

alsotop opened this issue Nov 3, 2015 · 4 comments

Comments

@alsotop
Copy link

alsotop commented Nov 3, 2015

Another couple of tokens that might be useful for commands would be the current deployer and committer. Not wanting to make too many tokens and make it messy, but perhaps {{ deployer_email }} {{ deployer_name }} {{ committer_email }} and {{ committer_name }}.

Example use case: we're using Rollbar, and we can notify Rollbar of a deploy being made by posting a webhook, and you can optionally provide the user who made the deploy.

@REBELinBLUE
Copy link
Owner

👍 Makes sense, I am away until next week so don't have a chance to do it but I will look early next week

@REBELinBLUE
Copy link
Owner

If a deployment is triggered via a webhook it is possible for the {{ deployer_name }} and {{ deployer_email }} to not have values.

What would you expect to happen in that case, blank values? The webhook can specify a name, so I guess {{ deployer_name }} would be the value specified via the hook otherwise webhook but not sure about email

@alsotop
Copy link
Author

alsotop commented Nov 12, 2015

Hmm, that's a good point. Well I suppose either it should fall back to blank values, or we could instead replace with a token that represents a "deploy source" (or something worded better) - and then either that is "webhook" or the username?

@REBELinBLUE
Copy link
Owner

Fixed in e8c7a6a

@REBELinBLUE REBELinBLUE removed the WIP label Jan 1, 2016
@REBELinBLUE REBELinBLUE changed the title Tokens for deployer and committer users Add tokens for deployer and committer users Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants