Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ghastly ghosts #982

Merged
merged 10 commits into from
Jan 30, 2023
Merged

Add Ghastly ghosts #982

merged 10 commits into from
Jan 30, 2023

Conversation

stilnat
Copy link
Contributor

@stilnat stilnat commented Jan 19, 2023 •
edited
Loading

Summary

Add ghosts when player dies (in command console (press F12), you can type "kill ckey" to kill someone, such as : "kill editorUser"

Known issues

  • The stamina UI is broken (ain't my fault, also on the main)

@TaylorNAlbarnaz TaylorNAlbarnaz added the Feature A new system or other feature. label Jan 19, 2023
@stilnat stilnat changed the title [WIP] Add Ghastly ghosts Add Ghastly ghosts Jan 19, 2023
cosmiccoincidence
cosmiccoincidence previously requested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@cosmiccoincidence cosmiccoincidence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the ghost fbx to the "Art" folder.
.fbx is a 3d model format, 3d models are created externally from Unity, external assets go in the Art folder.

Art/Models/ Entities/Humanoid/

@stilnat
Copy link
Contributor Author

stilnat commented Jan 20, 2023

Move the ghost fbx to the "Art" folder. .fbx is a 3d model format, 3d models are created externally from Unity, external assets go in the Art folder.

Art/Models/ Entities/Humanoid/

Fixed

TaylorNAlbarnaz
TaylorNAlbarnaz approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@TaylorNAlbarnaz TaylorNAlbarnaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@TaylorNAlbarnaz TaylorNAlbarnaz merged commit 99af9b8 into RE-SS3D:develop Jan 30, 2023
TaylorNAlbarnaz pushed a commit to TaylorNAlbarnaz/SS3D that referenced this pull request Feb 15, 2023
@stilnat @TaylorNAlbarnaz
Add Ghastly ghosts (RE-SS3D#982)
77b694c 
* add ghost controller and abstract humanoid controller

* Add base health controller

Basically can just kill player for now.

* Adds ghost prefab

* Few change on human prefab (add health controller)

* Add getSpawnedEntity, make method shorter

* Remove killing by pressing L

* Add Kill command

* Remove painful requireComponents

* Maek working Ghosts

* Move Human and Ghost .fbx file in the correct art folder.
@stilnat stilnat deleted the GhostForReal branch April 15, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaylorNAlbarnaz TaylorNAlbarnaz TaylorNAlbarnaz approved these changes

@joaoburatto joaoburatto Awaiting requested review from joaoburatto

@cosmiccoincidence cosmiccoincidence Awaiting requested review from cosmiccoincidence

Assignees
No one assigned
Labels
Feature A new system or other feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stilnat @TaylorNAlbarnaz @cosmiccoincidence