-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container system overhaul #1088
Merged
TaylorNAlbarnaz
merged 18 commits into
RE-SS3D:develop
from
stilnat:Container-system-overhaul
Mar 10, 2023
Merged
Container system overhaul #1088
TaylorNAlbarnaz
merged 18 commits into
RE-SS3D:develop
from
stilnat:Container-system-overhaul
Mar 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move some attached container logic to container. Remove custom icon per container.
TaylorNAlbarnaz
suggested changes
Mar 9, 2023
Assets/Scripts/SS3D/Systems/Inventory/Items/Identification/PDA.cs
Outdated
Show resolved
Hide resolved
TaylorNAlbarnaz
approved these changes
Mar 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improve the current container system in the following ways :
using a syncList to network changes to containers. Makes setting up a container easier, since there's only one script for it now to attach to a gameObject.
Globally, it's simpler to test, safer, has better reusability, and it's easier to set up for an user.
This PR also add an hack folder. This will contain little scripts that can be attached to game objects at run time to give an unfair advantage to a client over others. These could be later on used in play mode tests to check if the hacks are effective or not.
Technical Notes (optional)
I used an useful pattern to apply the humble object pattern when networking is involved, especially when synclists are involved. The idea is basically to use a reference in the non-behaviour object to the internal list of the synclist. The humble object ask for the non-behaviour to do stuff, and the non-behaviour object handles updating the list of the humble object.
To test the hack is effectively not working on client with this PR.
Future work
Todo
Fixes (optional)
close #969
close #970
close #971
close #1099