Add ServerOrClient attribute #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryan089
reviewed
Feb 14, 2023
Assets/Scripts/SS3D/Systems/Interactions/InteractionController.cs
Outdated
Show resolved
Hide resolved
Ryan089
reviewed
Feb 14, 2023
joaoburatto
approved these changes
Feb 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The ServerOrClient attribute simply allows to explicitly state that a given method can be called both by server and by a client.
This improve readability by a lot, at least for me.
It doesn't affect the code in any other way.
This PR also apply the attribute in the InteractionController code, and it adds client and server attributes on other methods lacking them (and which should be only called from client or server).