Relax dependencies on html5lib and SPARQLWrapper #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demote html5lib and SPARQLWrapper to from install_requires to tests_require and extras_require Closes: RDFLib#671
|
Thanks! |
joernhees
added
cleanup
enhancement
This was referenced Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demote html5lib and SPARQLWrapper to from install_requires to tests_require and extras_require
Closes: #671
i tried to balance code changes against code duplication here; depending on your style preferences, there are sure to be other ways of phrasing this.
this pull-request is similar to RDFLib/sparqlwrapper#79.
(side note: i thought that the python-version-dependent sections could be simplified as showin in a bug report example, but that still seems to be difficult to get right in presence of old versions).