-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix passing ConjunctiveGraph as namespace_manager #2073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mielvds thanks for the PR. While I think it is pretty safe and uncontroversial it would still be good to have tests for this.
Also, we are trying to reduce the effort it takes to make a release, and one part of this is to keep the changelog up to date always:
Lines 201 to 217 in cfa4180
<!-- --> | |
<!-- --> | |
<!-- CHANGE BARRIER: START --> | |
<!-- --> | |
<!-- --> | |
- PLACEHOLDER. | |
Description of changes. | |
Closed [issue #....](https://github.com/RDFLib/rdflib/issues/). | |
[PR #....](https://ichard26.github.io/next-pr-number/?owner=RDFLib&name=rdflib). | |
<!-- --> | |
<!-- --> | |
<!-- CHANGE BARRIER: END --> | |
<!-- --> | |
<!-- --> |
So it would be good if you could add tests and update the changelog, but I will try find some time this weekend to add tests and update the change on your PR branch if it is not done yet, as this is rather important to fix.
@mielvds please share how you managed to trigger this if you can. |
Hi @aucampia I triggered this while developing a documentation tool for shacl. I manage different shacl graphs as named graphs and got errors when printing the namespaces of individual graphs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for the test and changelog update @mielvds, the change looks good.
Summary of changes
NamespaceManager
of theConjunctiveGraph
as namespace_manager of theGraph
created by theget_context()
method instead of theConjunctiveGraph
object itself.Checklist
the same change.
./examples
for new features.so maintainers can fix minor issues and keep your PR up to date.