Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simple literals returned as NULL using SERVICE (issue #1278) #1894

Merged
merged 14 commits into from
May 15, 2022
Merged

Fix simple literals returned as NULL using SERVICE (issue #1278) #1894

merged 14 commits into from
May 15, 2022

Commits on May 8, 2022

  1. Refactor service json results parser to fix issue 1278 and align with… 

    … sparql/results/jsonresults parser.
    Mark van der Pas committed May 8, 2022
    Configuration menu
    Copy the full SHA
    2e71894 View commit details
    Browse the repository at this point in the history

  2. Add test for issue 1278 literals returned as null

    Mark van der Pas committed May 8, 2022
    Configuration menu
    Copy the full SHA
    f6d3e13 View commit details
    Browse the repository at this point in the history

  3. Fix formatting issue

    Mark van der Pas committed May 8, 2022
    Configuration menu
    Copy the full SHA
    e010508 View commit details
    Browse the repository at this point in the history

  4. Fix formatting issue evaluate.py

    Mark van der Pas committed May 8, 2022
    Configuration menu
    Copy the full SHA
    17bf257 View commit details
    Browse the repository at this point in the history

  5. Fix imports formatting issue

    Mark van der Pas committed May 8, 2022
    Configuration menu
    Copy the full SHA
    5ef9bdd View commit details
    Browse the repository at this point in the history

  6. fix test for literals returned as Null (#1278)

    Mark van der Pas committed May 8, 2022
    Configuration menu
    Copy the full SHA
    ccbdbc2 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Add test for SERVICE returning different node types

    Mark van der Pas committed May 11, 2022
    Configuration menu
    Copy the full SHA
    dde8b2d View commit details
    Browse the repository at this point in the history

  2. fix comment formatting

    Mark van der Pas committed May 11, 2022
    Configuration menu
    Copy the full SHA
    01f4515 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2022

  1. fix test data type

    Mark van der Pas committed May 12, 2022
    Configuration menu
    Copy the full SHA
    ad22370 View commit details
    Browse the repository at this point in the history

  2. move test from test_issue1278 to test_service

    @aucampia
    aucampia committed May 12, 2022
    Configuration menu
    Copy the full SHA
    c395200 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into issue1278_null_literals

    @aucampia
    aucampia authored May 12, 2022
    Configuration menu
    Copy the full SHA
    482f32a View commit details
    Browse the repository at this point in the history

  4. Add more tests 

    Also make existing tests stricter.
    @aucampia
    aucampia committed May 12, 2022
    Configuration menu
    Copy the full SHA
    8c1a293 View commit details
    Browse the repository at this point in the history

  5. Some minor improvements 

    - Use longer variable names so it is easier to read
- Add type hints
- Add comment explaining the reason for `typed-literal`
- Improved exception in case of invalid/unsupported type.
    @aucampia
    aucampia committed May 12, 2022
    Configuration menu
    Copy the full SHA
    e71b4a6 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. Merge remote-tracking branch 'upstream/master' into issue1278_null_li… 

    …terals
    @aucampia
    aucampia committed May 15, 2022
    Configuration menu
    Copy the full SHA
    6bd50f0 View commit details
    Browse the repository at this point in the history