Unify plugin loading #1694
Merged
Unify plugin loading #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220123T1926-plugin_loading
branch
2 times, most recently
from
e044140
to
4918ee7
Compare
aucampia
force-pushed
the
iwana-20220123T1926-plugin_loading
branch
from
4918ee7
to
1d57a24
Compare
nicholascar
approved these changes
Jan 25, 2022
aucampia
force-pushed
the
iwana-20220123T1926-plugin_loading
branch
from
1d57a24
to
6d7c8dd
Compare
Plugin loading in `rdflib.plugins.sparql` will now happen similar to what is being done for `rdflib.plugins`. This also eliminates a warning that occurs `rdflib.plugins.sparql` and makes it possible to enable `warn_unused_ignores` without any exceptions or workarounds. Also: - Removed unused `type: ignore` statements.
aucampia
force-pushed
the
iwana-20220123T1926-plugin_loading
branch
from
6d7c8dd
to
c069bc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin loading in
rdflib.plugins.sparqlwill now happen similar towhat is being done for
rdflib.plugins.This also eliminates a warning that occurs
rdflib.plugins.sparqlandmakes it possible to enable
warn_unused_ignoreswithout any exceptionsor workarounds.
Also:
type: ignorestatements.Fixes #1631