-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Result.serialize work more like Graph.serialize #1418
Conversation
77a09ae
to
efdd225
Compare
eb17439
to
3875f78
Compare
3875f78
to
abb01be
Compare
@nicholascar as this breaks the interface I will try to break of a bunch of these changes and merge them independently so that this can be minimal in size and deferred to 7.x. |
This commit only adds type hints and comments and does not make any changes that should affect runtime. The type hints added here derive from work done for RDFLib#1418.
This commit only adds type hints and comments and does not make any changes that should affect runtime. The type hints added here derive from work done for RDFLib#1418.
@aucampia since you are doing work elsewhere, do you want to put this PR on hold or to close it perhaps? |
This commit only adds type hints and comments and does not make any changes that should affect runtime. The type hints added here derive from work done for RDFLib#1418.
This commit only adds type hints and comments and does not make any changes that should affect runtime. The type hints added here derive from work done for RDFLib#1418.
This commit only adds type hints and comments and does not make any changes that should affect runtime. The type hints added here derive from work done for RDFLib#1418.
This commit only adds type hints and comments and does not make any changes that should affect runtime. The type hints added here derive from work done for RDFLib#1418.
This commit only adds type hints and comments and does not make any changes that should affect runtime. The type hints added here derive from work done for RDFLib#1418.
This commit only adds type hints and comments and does not make any changes that should affect runtime. The type hints added here derive from work done for RDFLib#1418.
This commit only adds type hints and comments and does not make any changes that should affect runtime. The type hints added here derive from work done for RDFLib#1418.
@nicholascar it's somewhat up to you. I feel this is ready to merge, if you only want to merge things that should go into 6.x then it is probably best to defer this, in which case I will proceed to break parts of this off into other PRs that won't break the interface and then proceed to have them merged. The other option is maybe to make a 6.x branch and then have master for 7.x but this may be more effort than it is worth. If we keep master for 6.x until we are ready to start work on 7.x then I will mark this as draft and proceed with merging the parts of this that does not break the interface and rebase this appropriately so that it has a minimal diff. |
I will anyway rebase this as other PRs are merged and keep this in a mergeable state at all times as best I can. |
@aucampia I see your other PRs with some of these parts in them, e.g. the type hinting additions. If we merge all those, I guess that will show the interface-breaking part here better. Then we can decide to merge into 6.0.x or 6.x.x or 7.x. So let's just wait on this for all those type hinting ones to go through! |
This commit only adds type hints and comments and does not make any changes that should affect runtime. The type hints added here derive from work done for RDFLib#1418.
abb01be
to
8729ed9
Compare
c4c7934
to
48322c8
Compare
Closing PR, no need to keep it open, I'm busy splitting stuff off though but it just clogs up the view. |
This patch makes the following changes to `Result.serialize`. * Return str by default instead of bytes. * Use "txt" as the default tabular serialization format. * Use "turtle" as the default graph serialization format. * Support both typing.IO[bytes] and typing.TextIO destinations. Corresponding changes are made to the specific serializers also. This patch also changes how text is written to typing.IO[bytes] in serializers to ensure that the buffer is flushed and detatched from the TextIOWrapper once the serialization function completes so it can be used normally afterwards. This patch further includes a bunch of additional type hints.
48322c8
to
2de6f76
Compare
DO NOT REVIEW: I'm going to split everything off from this that I can to reduce it to just the breaking changes so we can merge it before 7.0.0.
Reviewers beware: This patch is pretty big and contains a lot of things that could be merged separately. I may at some point break off some of the changes to separate PRs.This patch makes the following changes to
Result.serialize
.Corresponding changes are made to the specific serializers also.
This patch also changes how text is written to typing.IO[bytes] in
serializers to ensure that the buffer is flushed and
detatched from the TextIOWrapper once the serialization function
completes so it can be used normally afterwards.
This patch further includes a bunch of additional type hints.
Fixes #1338