-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop use_2to3 and restore rdflib interoperability #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch establishes the baseline state of unit tests passing. Unit test results: 5 tests report a FAIL status, all related to JSON-LD compaction. I suggest that these tests are out of scope of the mission of restoring builds functioning, related to removing the use_2to3 flag. References: * RDFLib/rdflib#1405 Signed-off-by: Alex Nelson <[email protected]>
The resolution of setuptools 2769 made any package using `use_2to3` to fail its build. This patch removes the flag, in support of outroducing rdflib-jsonld. The test suite is showing other follow-on patches will be necessary to fix matters 2to3 had been quietly fixing along the way. However, this first patch does restore a working call to `pip install .` with up-to-date setuptools. Unit test results: This causes only the same five tests as were previously failing to fail. setuptools versions tested: * 41.2.0 * 58.0.4 References: * pypa/setuptools#2769 * RDFLib/rdflib#1405 Reported-by: Ralf Grubenmann <[email protected]> Signed-off-by: Alex Nelson <[email protected]>
This is to prepare for rdflib 6.0.0. The original rename was performed in this rdflib commit: ceab6b2f71f97e45007b5306d2e0416bfefcea75 Unit test results: This causes only the same five tests as were previously failing to fail. Signed-off-by: Alex Nelson <[email protected]>
Unit test results: now reporting 135 errors, 1 failure (docstring). Signed-off-by: Alex Nelson <[email protected]>
The upstream signature had changed in this commit: 1a5df0084c6f361c9059ac19e64d632ae503b9b3 Unit test results: This patch addresses 124 of 135 errors raised in the unit tests. Failure (docstring) remains. Signed-off-by: Alex Nelson <[email protected]>
…ter strings Graph.serialize() returns either a character string or a byte string in rdflib 6.0.0. This patch addresses the errors reported by nosetests. Unit test results: This causes only the same five tests as were initially failing to fail. Signed-off-by: Alex Nelson <[email protected]>
This docstring was a new test failure reported by nosetests when trying one last time to pin rdflib to pre-6.0.0. With this patch, test results match when using rdflib 5.0.0 or 6.0.0. Unit test results: This causes only the same five tests as were initially failing to fail. setuptools versions tested: * 41.2.0 * 58.0.4 Signed-off-by: Alex Nelson <[email protected]>
nicholascar
approved these changes
Sep 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all this preservation work @ajnelson-nist
ajnelson-nist
added a commit
to ajnelson-nist/rdflib-jsonld
that referenced
this pull request
Sep 13, 2021
This was accidentally removed as part of this pull request: RDFLib#105 Signed-off-by: Alex Nelson <[email protected]>
This is unexpected but thank you. This helps doing the transition with the setuptools issues. |
BryceStevenWilley
added a commit
to BryceStevenWilley/mealie
that referenced
this pull request
Sep 20, 2021
`extruct` depends on rdflib-jsonld, which had an error involving `use_2to3` (RDFLib/rdflib-jsonld#105), which prevented building.
roblinksdata
pushed a commit
to ONSdigital/csvcubed
that referenced
this pull request
Sep 20, 2021
roblinksdata
pushed a commit
to ONSdigital/csvcubed
that referenced
this pull request
Sep 20, 2021
canwaf
pushed a commit
to ONSdigital/csvcubed
that referenced
this pull request
Sep 20, 2021
…kage files (#176) * Upgrading rdflib-jsonld due to breaking change in latest version of python. RDFLib/rdflib-jsonld#105 * Ensuring that the devtools package actually includes the relevant package files.
hay-kot
added a commit
to mealie-recipes/mealie
that referenced
this pull request
Sep 23, 2021
* Shopping list quantity decrement button -> minus Missed being renamed when material design icons were moved to be global variables, still used the original md name. * Updated poetry lock to fix rdflib-jsonld error `extruct` depends on rdflib-jsonld, which had an error involving `use_2to3` (RDFLib/rdflib-jsonld#105), which prevented building. * update poetry CI/CD Version Co-authored-by: Hayden <[email protected]>
hay-kot
added a commit
to mealie-recipes/mealie
that referenced
this pull request
Dec 1, 2021
* Shopping list quantity decrement button -> minus Missed being renamed when material design icons were moved to be global variables, still used the original md name. * Updated poetry lock to fix rdflib-jsonld error `extruct` depends on rdflib-jsonld, which had an error involving `use_2to3` (RDFLib/rdflib-jsonld#105), which prevented building. * update poetry CI/CD Version Co-authored-by: Hayden <[email protected]>
hay-kot
added a commit
to mealie-recipes/mealie
that referenced
this pull request
Dec 1, 2021
* Shopping list quantity decrement button -> minus Missed being renamed when material design icons were moved to be global variables, still used the original md name. * Updated poetry lock to fix rdflib-jsonld error `extruct` depends on rdflib-jsonld, which had an error involving `use_2to3` (RDFLib/rdflib-jsonld#105), which prevented building. * update poetry CI/CD Version Co-authored-by: Hayden <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series has two goals:
use_2to3
flag fromsetup.py
, as setuptools#2770 setthat flag to trigger an error. (Further discussion might ensue on
setuptools#2779.)
state archived in July, whether rdflib 5.0.0 or 6.0.0 is present.
(NOTE - it appears to me that unit tests do not pass in the July
state, and this is noted in the first patch, which establishes the
testing baseline. The end effect of this patch series leaves no new
known failures.)
Together, these will make
rdflib-jsonld
continue to be a transparentimport, aiding users that did not realize, or cannot accommodate, that
the package had been integrated into rdflib.
More pragmatically, downstream builds depending on rdflib-jsonld should
no longer halt on reaching this dependency.
How to socialize the package being deprecated is left for a separate
patch series.
Tests were run with the following script, commenting out some portions
when fail states were expected:
References:
Signed-off-by: Alex Nelson [email protected]