Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially wrong location of the py.typed file #267

Closed
s-heppner opened this issue Oct 10, 2024 · 1 comment · Fixed by #268
Closed

Potentially wrong location of the py.typed file #267

s-heppner opened this issue Oct 10, 2024 · 1 comment · Fixed by #268

Comments

@s-heppner
Copy link

Could it be that the py.typed file should actually be located in the ./pyshacl directory?
We've been having problems with mypy in our CI-pipeline of the PR: eclipse-basyx/basyx-python-sdk#308:

error: Skipping analyzing "pyshacl": module is installed, but missing library stubs or py.typed marker  [import-untyped]

I'm no expert on PEP 561 myself, but it seems in this example, the py.typed file is actually located on the same level as the top-level __init__.py.

@ashleysommer
Copy link
Collaborator

Thanks for this report. The py.typed file was added by another contributor a few years ago, and I assumed it was in the correct location. I'll look into if it needs to be changed.

s-heppner added a commit to rwth-iat/basyx-python-sdk that referenced this issue Nov 6, 2024
Previously, we used version 0.26.0 of pyshacl.
This version however had a problem with typing,
namely the `py.typed` file was in the wrong
location (see [pyshacl#267]).

This has been fixed in this new release, therefore
we bump the version number in our dependency
declaration.

This also should fix our CI Pipeline.

[pyshacl#267]: RDFLib/pySHACL#267
s-heppner added a commit to rwth-iat/basyx-python-sdk that referenced this issue Nov 6, 2024
Previously, we used version 0.26.0 of pyshacl.
This version however had a problem with typing,
namely the `py.typed` file was in the wrong
location (see [pyshacl#267]).

This has been fixed in this new release, therefore
we bump the version number in our dependency
declaration.

This also should fix our CI Pipeline.

[pyshacl#267]: RDFLib/pySHACL#267
s-heppner added a commit to rwth-iat/basyx-python-sdk that referenced this issue Nov 6, 2024
Previously, we used version 0.26.0 of pyshacl.
This version however had a problem with typing,
namely the `py.typed` file was in the wrong
location (see [pyshacl#267]).

This has been fixed in this new release, therefore
we bump the version number in our dependency
declaration.

This also should fix our CI Pipeline, as we both
fix the mypy issues, as well as some pycodestyle
ones.

[pyshacl#267]: RDFLib/pySHACL#267
s-heppner added a commit to eclipse-basyx/basyx-python-sdk that referenced this issue Nov 12, 2024
Previously, we used version 0.26.0 of pyshacl.
This version however had a problem with typing,
namely the `py.typed` file was in the wrong
location (see [pyshacl#267]).

This has been fixed in this new release, therefore
we bump the version number in our dependency
declaration.

This also should fix our CI Pipeline, as we both
fix the mypy issues, as well as some pycodestyle
ones.

[pyshacl#267]: RDFLib/pySHACL#267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants