Downstream testing trial #744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bdegraaf1234
force-pushed
the
downstream-testing
branch
5 times, most recently
from
18170d6 to
d40d72f
Compare
…sonal access token this will fail
…ondition ("if pullrequest") for testing. revert this later
Bdegraaf1234
force-pushed
the
downstream-testing
branch
2 times, most recently
from
a010e82 to
3177a48
Compare
Bdegraaf1234
force-pushed
the
downstream-testing
branch
from
3177a48 to
ede8780
Compare
|
I think we can merge this, the largest change are the docker-compose files but a restructuring here is probably needed for the ory change because this will add a number of components that need to be launched to run MP |
Bdegraaf1234
requested review from
nivemaham,
blootsvoets and
peyman-mohtashami
as code owners
baixiac
reviewed
Nov 29, 2023
| managementportal-postgresql: | ||
| extends: | ||
| file: ../postgresql.yml | ||
| service: managementportal-postgresql |
There was a problem hiding this comment.
The service has been renamed to postgresql in ../postgresql.yml.
Is this "non_mp" compose file intended for all devs? If yes, it would be nicer to have an example showing how to use it.
|
The most important changes here are the ones in main.yml, the rest is probably redundant when you update the base |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added a github action which, on merging a branch into dev/master triggers downstream tests agains the built docker image
An alternative way to do this would be to pull the downstream repo and run the tests, but this seems more messy. It does however keep any failing pipelines close to the source (in this case, the changes to management portal)
Checklist: