Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Only fetch profiles if a game path is available #500

Merged
merged 11 commits into from
Oct 6, 2023
Merged

fix: Only fetch profiles if a game path is available #500

merged 11 commits into from
Oct 6, 2023

Conversation

Jan200101
Copy link
Contributor

fixes #499

@GeckoEidechse GeckoEidechse changed the title Only fetch profiles if a game path is available fix: Only fetch profiles if a game path is available Aug 8, 2023
GeckoEidechse
GeckoEidechse approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing

GeckoEidechse
GeckoEidechse reviewed Aug 8, 2023
View reviewed changes
src-vue/src/plugins/store.ts Outdated Show resolved Hide resolved
src-vue/src/plugins/store.ts Outdated Show resolved Hide resolved
@GeckoEidechse GeckoEidechse mentioned this pull request Aug 8, 2023
Closed
@Jan200101
Copy link
Contributor Author

I consulted this solution and found that it still yields problems.
All of these problems originate from the fact we use GameInstall now all over the place.
I'll look into the best way to solve this without having to duplicate the code 20 dozen times.

@Jan200101
Copy link
Contributor Author

Should work without issues now.

GeckoEidechse
GeckoEidechse approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing on Fedora 38.

Checked behaviour when game install path is not set and when game install path is set.

@GeckoEidechse GeckoEidechse merged commit ed888c8 into R2NorthstarTools:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile related error message pops up when no Titanfall2 install is found
2 participants
@Jan200101 @GeckoEidechse