Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refetch profiles when opening SettingsView #498

Merged
merged 5 commits into from
Oct 9, 2023
Merged

fix: Refetch profiles when opening SettingsView #498

merged 5 commits into from
Oct 9, 2023

Conversation

Jan200101
Copy link
Contributor

@Jan200101 Jan200101 commented Aug 8, 2023

Refetches profiles every time we open the SettingsView, like the local mod view does.

@Jan200101
Copy link
Contributor Author

based on #444

@GeckoEidechse
Copy link
Member

alternatively we could refetch profiles every time we open the SettingsView, like the local mod view does.

Yeah, probably the better way. Unless you need that button specifically I would skip adding it to DevView. When in #444 I mentioned adding buttons to call certain backend functions in spliced out PRs I meant before the frontend logic that actually calls them is implemented ^^"

@Jan200101
Copy link
Contributor Author

alright.
This was inspired by the existing button in the DevView that is kinda pointless:
image

I'll move the profile fetching from store to settingsview mount callback.

@Jan200101 Jan200101 changed the title add dev button to refetch profiles refetch profiles when opening Settings and when changing game directory Aug 8, 2023
@GeckoEidechse GeckoEidechse changed the title refetch profiles when opening Settings and when changing game directory Fix: Refetch profiles when opening SettingsView Oct 9, 2023
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working testing on Fedora 38 by creating a new folder in Titanfall2 dir and making it look like a profile folder. Then switching from and to SettingsView and having new profile folder show up.

@GeckoEidechse GeckoEidechse changed the title Fix: Refetch profiles when opening SettingsView fix: Refetch profiles when opening SettingsView Oct 9, 2023
@GeckoEidechse GeckoEidechse merged commit cb2bc0d into R2NorthstarTools:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants