-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add dropdown menu for profiles #494
feat: Add dropdown menu for profiles #494
Conversation
Had to fix a small issue where the first commit did not have a missing import (how this evaded me is unknown, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In quick test, switching profile does not updated the detected version in PlayView.
UI wise, there should maybe also be some explainer of what profiles are. Maybe a small Personally I'd still suggest to gate profile selecting behind DevView for now so that we can skip all these small UI quirks to that are kinda needed to make the feature "end-user compatible" and so that we can already test it with contributors. Then we could even do a 3.0 release where we basically just move it from DevView to RepairView when deemed stable enough ^^ |
I had only picked the first commit, as you requested. |
Validated that the verison is now updated when changing the profile by switching to R2Ronin (which FlightCore cannot detect but is still a valid Profile) |
Future:tm:
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed working on Windows and Linux (skipped actually launching the game on Linux cause no working Titanfall2 install)
Requested code changes have been addressed and there isn't anything major I'd change with this PR rn. We could move the SKIP_PATHS
and MAY_CONTAIN
to constant.rs
but I don't really see too much of a need to do so rn ^^
So good to merge from my end :D
based on #444 |
add dropdown menu for profiles