feat: Show download progress for installing Northstar #200
Conversation
This adds a change needed for making progressbar work on dowload
Simply prints it to JavaScript console for now
|
Currently this is done using events which is fine but I need to pass the window handle all the way down to the install function which is annoying. If I could somehow instead grab the default window or something similar that doesn't require me to pass the window object all the way down, that would be great ^^ |
If we spam emit too much we use a lot of extra resources, slowing down the actual download
|
Okay, I think I got the basics figured out. From here I "only" need to refactor and settle on a format for transmitting data... @Alystrasz I assume I just transfer the raw info, i.e. downloaded bytes and total size and then do the calculation on the frontend? |
Yep you only need those two values to display download progress in UI :) Do you plan to distinguish between archive downloading and extraction? |
Yes. I guess the way to go would be to also supply an enum in the message that indicates the state i.e. |
That's what I ended up doing, yep |
Alright, should be implemented now. For now it simply does a
|
|
Why do you only have 3 download updates? |
It sends an update every 250ms. However if you have a 1gbps downlink, that means that those 70MB of Northstar zip get downloaded in less than a second, i.e. only 3 updates sent out before download is done xD
Don't know yet how to do progress tracking of the extraction unfortunately so I can only emit starting (and done if wanted). Need to learn more Rust before I know how to do callbacks from extract but that's gonna take a few weeks based on how much time I can invest into this atm :/ |
|
Tried a bit with implementing a progress bar myself but I'm failing on actually listening to the event in the right Vue component... ^^" |
|
Aight, I got some rudimentary progress bar done now. Only issue is that CSS seems to be squishing it to the point that it becomes invisible but I have no idea how to fix that... |
do not show downloaded size anymore during extraction
|
Manually specified progress bar size via CSS now in 4449a4d Feels a bit like a hack, probably also is one, but it works and tbh we really need to get a version with progress bar out cause it's the only feature that Viper has that we still don't have ^^ |
instead of 250ms Gives impression of faster / more fluent download.
|
@GeckoEidechse I reworked your PR a bit, feel free to review again (I can't request your review through GitHub since you're the PR author). |
Looks good so far, many thanks <3 I'll try to address the remaining issues now. Maybe I'll come across anything in the process :P |
|
Alright, done again from my side now. Back to you for review :P |
Still WIP. The end goal would be to have a way to show download and install progress of Northstar.
Right now we do not show any progress which is frustrating to anyone where the install takes longer than a few seconds.
TODO: