Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move various consts to constants.rs #162

Merged
merged 5 commits into from
Feb 11, 2023
Merged

refactor: Move various consts to constants.rs #162

merged 5 commits into from
Feb 11, 2023

Conversation

GeckoEidechse
Copy link
Member

@GeckoEidechse GeckoEidechse commented Feb 5, 2023 •
edited
Loading

Move

  • list of core Northstar mods
  • list of blacklisted mods
  • list of Titanfall2 Origin game IDs

to constants.rs

This should cover all remaining constants.

@GeckoEidechse
refactor: Move list of core mods to consts source
2baea1b 
Move the list of core Northstar mods to constants.rs
@GeckoEidechse GeckoEidechse changed the title refactor: Move list of core mods to consts source refactor: Move various consts to constants.rs Feb 6, 2023
Alystrasz
Alystrasz approved these changes Feb 11, 2023
View reviewed changes
Copy link
Contributor

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Confirmed working on Windows.

@Alystrasz Alystrasz merged commit fc00447 into main Feb 11, 2023
@Alystrasz Alystrasz deleted the refactor/move-to-consts branch February 11, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alystrasz Alystrasz Alystrasz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeckoEidechse @Alystrasz