Fix memory leak in scripthttprequesthandler.cpp #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
|
@xCynDev can you provide detailed instructions to test your PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few calls to
freeaddrinfo()that were missing (mostly when returning false inIsHttpDestinationHostAllowed()).Code review:
Not much, check where I've added
freeaddrinfo().Testing:
Check that it works on your end by making an HTTP call to a non-local, IPv6 address (without
-allowlocalhttp!)And then also make a call to a local IPv4 host, again without
-allowlocalhttp.If you don't crash and the requests
workget rejected, it's all good.