mods: Move collecting mods to own function

[Alystrasz]

In the same fashion than #829, extracts some ModManager code into a dedicated method (and adds some documentation as a bonus).

[GeckoEidechse]

Is there a reason we don't return anything from the helper function and instead directly store it in the method field?

As opposed to calling the helper function, returning the collected information and then storing it in the field?

(Not saying it needs to be changed, just curious ^^)

[Alystrasz]

Is there a reason we don't return anything from the helper function and instead directly store it in the method field?
As opposed to calling the helper function, returning the collected information and then storing it in the field?
(Not saying it needs to be changed, just curious ^^)

I simply exported some code into this new function, that initializes the m_LoadedMods variable state of the ModManager instance; I thought of it as a kind of __init__ function, that does not necessarily need to return something :)

[GeckoEidechse]

Open questions have been addressed. Just moves code around as verified when checking locally.

Apart from the return value aspect which I'd be happy for someone else to also comment on this should be good from the code review side of things ^^

[GeckoEidechse]

Tbh, not even sure if this needs testing or not. Could just test in prod.

[NachosChipeados]

Works fine, played an entire match with no issues