Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Remove use of SourceInterface for IFileSystem #805

Merged
merged 5 commits into from
Sep 5, 2024
Merged

core: Remove use of SourceInterface for IFileSystem #805

merged 5 commits into from
Sep 5, 2024

Conversation

F1F7Y
Copy link
Member

@F1F7Y F1F7Y commented Aug 31, 2024

Code review:

Look at code

Testing:

We use filesystem for mods so as long as your mods mount everything should be fine i think.

@github-actions github-actions bot added needs testing Changes from the PR still need to be tested needs code review Changes from PR still need to be reviewed in code labels Aug 31, 2024
GeckoEidechse
GeckoEidechse approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@GeckoEidechse GeckoEidechse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working in testing as per instructions as can be seen from the custom main menu background added by a mod

image

@GeckoEidechse GeckoEidechse added almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge and removed needs testing Changes from the PR still need to be tested labels Sep 2, 2024
RoyalBlue1
RoyalBlue1 previously requested changes Sep 2, 2024
View reviewed changes
primedev/core/filesystem/filesystem.cpp Outdated Show resolved Hide resolved
primedev/mods/modmanager.cpp Outdated Show resolved Hide resolved
ASpoonPlaysGames
ASpoonPlaysGames requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code mostly looks good, just some unnecessary &* going on

primedev/mods/modmanager.cpp Outdated Show resolved Hide resolved
primedev/core/filesystem/filesystem.cpp Outdated Show resolved Hide resolved
primedev/core/filesystem/filesystem.cpp Outdated Show resolved Hide resolved
primedev/core/filesystem/filesystem.cpp Outdated Show resolved Hide resolved
@ASpoonPlaysGames
Copy link
Contributor

bruh i got review sniped

@GeckoEidechse GeckoEidechse added the waiting on changes by author Waiting on PR author to implement the suggested changes label Sep 2, 2024
@F1F7Y F1F7Y removed the waiting on changes by author Waiting on PR author to implement the suggested changes label Sep 2, 2024
ASpoonPlaysGames
ASpoonPlaysGames approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@ASpoonPlaysGames ASpoonPlaysGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@GeckoEidechse GeckoEidechse dismissed RoyalBlue1’s stale review September 5, 2024 13:21

Requested changes have since been addressed

@GeckoEidechse GeckoEidechse merged commit 27f478e into R2Northstar:main Sep 5, 2024
4 checks passed
wolf109909 pushed a commit to R2NorthstarCN/NorthstarLauncher that referenced this pull request Sep 8, 2024
@F1F7Y @wolf109909
core: Remove use of SourceInterface for IFileSystem (R2Northstar#805
4853916 
)

`SourceInteface` class goes back to icepick and is not good. We have a replacement, let's use it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASpoonPlaysGames ASpoonPlaysGames ASpoonPlaysGames approved these changes

@GeckoEidechse GeckoEidechse GeckoEidechse approved these changes

@RoyalBlue1 RoyalBlue1 RoyalBlue1 left review comments

Assignees
No one assigned
Labels
almost ready to merge Apart from any small remaining other issues addressed by other labels, this would be ready to merge needs code review Changes from PR still need to be reviewed in code
Projects
Northstar Roadmap
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@F1F7Y @ASpoonPlaysGames @RoyalBlue1 @GeckoEidechse