Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strtoull instead of strtoll for uint64s #198

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

KittenPopo
Copy link
Contributor

I have no proof that this will actually ever cause a real problem, but it's definitely a good idea and is more proper.

@GeckoEidechse
Copy link
Member

Note to self:

  • strtoll: Convert string to long long integer
  • strtoull: Convert string to unsigned long long integer

@KittenPopo
Copy link
Contributor Author

KittenPopo commented Jun 17, 2022

Note to self:

  • strtoll: Convert string to long long integer
  • strtoull: Convert string to unsigned long long integer

strtoll = str-to-LL (long long)
strtoull = str-to-U-L-L (unsigned long long)
strtol = str-to-L (long/int)

Once you realize the pattern its pretty helpful xD

@GeckoEidechse
Copy link
Member

To hit those lines in testing I assume I just to put someone on banlist and then have them join server? ^^

@KittenPopo
Copy link
Contributor Author

To hit those lines in testing I assume I just to put someone on banlist and then have them join server? ^^

... Yes.

Not sure why a 1-character function usage switch of a super common STL function needs testing, but go for it xD

@GeckoEidechse
Copy link
Member

To hit those lines in testing I assume I just to put someone on banlist and then have them join server? ^^

... Yes.

Not sure why a 1-character function usage switch of a super common STL function needs testing, but go for it xD

Eh, like the issue is not gonna be in a standard lib function. More so in the change from one function to the other. And like I don't expect anything to break either. It's mostly about establishing a pattern of testing every PR for the stuff it changes.

Anyway, noticed no issues in testing ^^

@GeckoEidechse GeckoEidechse merged commit 0ffee77 into R2Northstar:main Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants