support ocrmypdf#32 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command resultsDetails:Run doctocchanged:
- /home/runner/work/workflow_ocr/workflow_ocr/README.md
unchanged:Changed filesChanged file:
|
Repo
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=============================================
+ Coverage 77.57% 99.53% +21.96%
+ Complexity 111 83 -28
=============================================
Files 16 13 -3
Lines 330 217 -113
=============================================
- Hits 256 216 -40
+ Misses 74 1 -73
Continue to review full report at Codecov.
|
…/workflow_ocr into feature/support_ocrmypdf#32
Closed
5 tasks
bahnwaerter
previously requested changes
Nov 30, 2020
There was a problem hiding this comment.
Thanks @R0Wi for your great work. I've tested your pull request on a fresh Nextcloud 20.0.2 instance using OCRmyPDF in version 11.3.3. The OCR processing succeeds, but ignores bitmap images in a mixed file document (images embedded into text pages). Therefore, please consider my suggestion to solve this issue by changing the parameter of the OCRmyPDF command line call.
Co-authored-by: Manuel Bentele <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions bot
pushed a commit
that referenced
this pull request
Nov 30, 2020
* First working version with OCRmyPDF #32 * Fix variable assignment * Use ProcessingFileAccessor to prevent infinite loop * Update README for OCRmyPDF * docs: update TOC * Update README + app compliance * Code compliance * Apply suggestions from code review Co-authored-by: Manuel Bentele <[email protected]> Co-authored-by: R0Wi <[email protected]> Co-authored-by: Manuel Bentele <[email protected]>
R0Wi
added a commit
that referenced
this pull request
Nov 30, 2020
* First working version with OCRmyPDF #32 * Fix variable assignment * Use ProcessingFileAccessor to prevent infinite loop * Update README for OCRmyPDF * docs: update TOC * Update README + app compliance * Code compliance * Apply suggestions from code review Co-authored-by: Manuel Bentele <[email protected]> Co-authored-by: R0Wi <[email protected]> Co-authored-by: Manuel Bentele <[email protected]> Co-authored-by: Robin Windey <[email protected]> Co-authored-by: R0Wi <[email protected]> Co-authored-by: Manuel Bentele <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.