Implement feature #88 #143
Conversation
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 131 142 +11
===========================================
Files 25 26 +1
Lines 481 527 +46
Branches 4 6 +2
===========================================
+ Hits 481 527 +46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@bahnwaerter coverage tracking in JS seems to be fixed again. Unfortunately Codecov doesn't report it correctly at the moment. If you look at the Github action it will show you a 100% coverage in JS. Also if you run the coverage locally it works fine
|
There was a problem hiding this comment.
This patch looks good to me, except for two minor problems regarding code format style. I reviewed all code changes but have not done any manual testing of this new feature on a fresh Nextcloud installation. The creator of the feature request has already tested the first working implementation of this patch and couldn't observe any errors. Therefore, feel free to release this new feature after solving the two minor code format style issues.
Co-authored-by: Manuel Bentele <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
* Implement assign tags / remove tags after OCR has finished Closing #88 * Update tests/Unit/Service/OcrServiceTest.php Co-authored-by: Manuel Bentele <[email protected]> Co-authored-by: Manuel Bentele <[email protected]>
* Implement assign tags / remove tags after OCR has finished Closing #88 * Update tests/Unit/Service/OcrServiceTest.php Co-authored-by: Manuel Bentele <[email protected]> Co-authored-by: Manuel Bentele <[email protected]> Co-authored-by: Manuel Bentele <[email protected]>
No description provided.