Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uid from filepath #116

Merged
merged 1 commit into from
May 11, 2022
Merged

Use uid from filepath #116

merged 1 commit into from
May 11, 2022

Conversation

R0Wi
Copy link
Contributor

@R0Wi R0Wi commented May 7, 2022

@R0Wi R0Wi requested a review from bahnwaerter May 7, 2022 18:33
@R0Wi R0Wi self-assigned this May 7, 2022
@R0Wi R0Wi linked an issue May 7, 2022 that may be closed by this pull request
File was not found because wrong user id #110
Closed
@codecov
Copy link

codecov bot commented May 7, 2022 •
edited
Loading

Codecov Report

Merging #116 (b30fb27) into master (99c8218) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##              master      #116   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       128       125    -3     
===========================================
  Files             23        23           
  Lines            466       457    -9     
  Branches           4         4           
===========================================
- Hits             466       457    -9
Impacted Files Coverage Δ
lib/BackgroundJobs/ProcessFileJob.php 100.00% <100.00%> (ø)
lib/Operation.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99c8218...b30fb27. Read the comment docs.

@R0Wi R0Wi force-pushed the bugfix/fileowner#110 branch from 8b4f8aa to 6d75d1f Compare May 7, 2022 18:39
@R0Wi
Use uid from filepath
b30fb27 
* Read user id from filepath, don't use fileowner
* Use new \OCP\BackgroundJob\QueuedJob base class
* Closing #110
@R0Wi R0Wi force-pushed the bugfix/fileowner#110 branch from 6d75d1f to b30fb27 Compare May 7, 2022 18:56
@sonarcloud
Copy link

sonarcloud bot commented May 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@R0Wi R0Wi marked this pull request as ready for review May 7, 2022 19:49
@R0Wi R0Wi mentioned this pull request May 7, 2022
Closed
bahnwaerter
bahnwaerter approved these changes May 10, 2022
View reviewed changes
Copy link
Collaborator

@bahnwaerter bahnwaerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @R0Wi for your issue #110 fix. The patch looks fine to me. Feel free to test and release this bug fix.

@R0Wi R0Wi merged commit 3b0f56a into master May 11, 2022
@R0Wi R0Wi deleted the bugfix/fileowner#110 branch May 11, 2022 05:42
@R0Wi
Copy link
Contributor Author

R0Wi commented May 11, 2022

The backport to stable23 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-stable23 stable23
# Navigate to the new working tree
cd .worktrees/backport-stable23
# Create a new branch
git switch --create backport-116-to-stable23
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick ---mainline 1 3b0f56a6c6d4e034a02771a539f64648aaf48b7d
# Push it to GitHub
git push --set-upstream origin backport-116-to-stable23
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-stable23

Then, create a pull request where the base branch is stable23 and the compare/head branch is backport-116-to-stable23.

R0Wi added a commit that referenced this pull request May 11, 2022
@R0Wi @github-actions
Use uid from filepath (#116)
65bed02 
* Read user id from filepath, don't use fileowner
* Use new \OCP\BackgroundJob\QueuedJob base class
* Closing #110
@R0Wi R0Wi mentioned this pull request May 11, 2022
Merged
R0Wi added a commit that referenced this pull request May 11, 2022
@R0Wi
Use uid from filepath (#116) (#117)
adc51dd 
* Read user id from filepath, don't use fileowner
* Use new \OCP\BackgroundJob\QueuedJob base class
* Closing #110
R0Wi added a commit that referenced this pull request May 11, 2022
@R0Wi
Use uid from filepath (#116)
aa4ffff 
* Read user id from filepath, don't use fileowner
* Use new \OCP\BackgroundJob\QueuedJob base class
* Closing #110
@R0Wi R0Wi mentioned this pull request May 11, 2022
Merged
R0Wi added a commit that referenced this pull request May 11, 2022
@R0Wi
Use uid from filepath (#116) (#118)
73cb6cd 
* Read user id from filepath, don't use fileowner
* Use new \OCP\BackgroundJob\QueuedJob base class
* Closing #110
@yharroch
Copy link

I tried this new version.
Everything was fine 👌
Thanks a lot

@R0Wi
Copy link
Contributor Author

R0Wi commented May 11, 2022

Thank's for your feedback. The fix will be released with the next version for NC23 and NC24 😎

@R0Wi R0Wi added this to the v1.23.3 milestone May 11, 2022
@XueSheng-GIT XueSheng-GIT mentioned this pull request Dec 14, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bahnwaerter bahnwaerter bahnwaerter approved these changes

Assignees

@R0Wi R0Wi

Labels
backport stable23 backport stable24
Projects
None yet
Milestone
v1.23.3
Development

Successfully merging this pull request may close these issues.

File was not found because wrong user id
3 participants
@R0Wi @yharroch @bahnwaerter